Skip to content

Places render after abort#59

Open
dkastl wants to merge 1 commit intomasterfrom
unknown repository
Open

Places render after abort#59
dkastl wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@dkastl
Copy link
Copy Markdown

@dkastl dkastl commented Jan 30, 2018

When running npm start the build fails with:

ERROR in ./src/components/fetch-wrapper.jsx

/path/to/react-file-viewer/src/components/fetch-wrapper.jsx
  31:5  error  render should be placed after abort  react/sort-comp

✖ 1 problem (1 error, 0 warnings)

By changing the order as suggested the error seems to be resolved.

You mention a CLA in the contributing guidelines. However it's not clear how to submit this. I can't find any bot, that could fail to recognize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 30, 2018

CLA assistant check
All committers have signed the CLA.

@dkastl
Copy link
Copy Markdown
Author

dkastl commented Jan 30, 2018

OK, CLA problem was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants